let clang-tidy add missing override after enabling again the check

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

src/3rdparty/QProgressIndicator/QProgressIndicator.h

@@ -67,8 +67,8 @@ public:
       */
     const QColor & color() const { return m_color; }
 
-    virtual QSize sizeHint() const;
-    int heightForWidth(int w) const;
+    QSize sizeHint() const override;
+    int heightForWidth(int w) const override;
 public slots:
     /*! Starts the spin animation.
         \sa stopAnimation isAnimated
@@ -98,8 +98,8 @@ public slots:
      */
     void setColor(const QColor & color);
 protected:
-    virtual void timerEvent(QTimerEvent * event); 
-    virtual void paintEvent(QPaintEvent * event);
+    void timerEvent(QTimerEvent * event) override;
+    void paintEvent(QPaintEvent * event) override;
 private:
     int m_angle = 0;
     int m_timerId = -1;

src/3rdparty/qtlockedfile/qtlockedfile.h

@@ -57,7 +57,7 @@ public:
 
     QtLockedFile();
     QtLockedFile(const QString &name);
-    ~QtLockedFile();
+    ~QtLockedFile() override;
 
     bool lock(LockMode mode, bool block = true);
     bool unlock();

src/3rdparty/qtsingleapplication/qtsingleapplication.h

@@ -44,7 +44,7 @@ class QtSingleApplication : public QApplication
 
 public:
     QtSingleApplication(const QString &id, int &argc, char **argv);
-    ~QtSingleApplication();
+    ~QtSingleApplication() override;
 
     bool isRunning(qint64 pid = -1);
 

src/common/checksums.h

@@ -81,7 +81,7 @@ class OCSYNC_EXPORT ComputeChecksum : public QObject
     Q_OBJECT
 public:
     explicit ComputeChecksum(QObject *parent = nullptr);
-    ~ComputeChecksum();
+    ~ComputeChecksum() override;
 
     /**
      * Sets the checksum type to be used. The default is empty.

src/common/syncjournaldb.h

@@ -47,7 +47,7 @@ class OCSYNC_EXPORT SyncJournalDb : public QObject
     Q_OBJECT
 public:
     explicit SyncJournalDb(const QString &dbFilePath, QObject *parent = nullptr);
-    virtual ~SyncJournalDb();
+    ~SyncJournalDb() override;
 
     /// Create a journal path for a specific configuration
     static QString makeDbName(const QString &localPath,

src/common/vfs.h

@@ -126,7 +126,7 @@ public:
 
 public:
     explicit Vfs(QObject* parent = nullptr);
-    virtual ~Vfs();
+    ~Vfs() override;
 
     virtual Mode mode() const = 0;
 
@@ -291,7 +291,7 @@ class OCSYNC_EXPORT VfsOff : public Vfs
 
 public:
     VfsOff(QObject* parent = nullptr);
-    virtual ~VfsOff();
+    ~VfsOff() override;
 
     Mode mode() const override { return Vfs::Off; }
 

src/csync/csync_exclude.h

@@ -69,7 +69,7 @@ public:
     using Version = std::tuple<int, int, int>;
 
     explicit ExcludedFiles(const QString &localPath = QStringLiteral("/"));
-    ~ExcludedFiles();
+    ~ExcludedFiles() override;
 
     /**
      * Adds a new path to a file containing exclude patterns.

src/gui/accountmanager.h

@@ -28,7 +28,7 @@ class AccountManager : public QObject
     Q_OBJECT
 public:
     static AccountManager *instance();
-    ~AccountManager() = default;
+    ~AccountManager() override = default;
 
     /**
      * Saves the accounts to a given settings file

src/gui/accountsettings.h

@@ -55,7 +55,7 @@ class AccountSettings : public QWidget
 
 public:
     explicit AccountSettings(AccountState *accountState, QWidget *parent = nullptr);
-    ~AccountSettings();
+    ~AccountSettings() override;
     QSize sizeHint() const override { return ownCloudGui::settingsDialogSize(); }
     bool canEncryptOrDecrypt(const FolderStatusModel::SubFolderInfo* folderInfo);
 

src/gui/accountstate.h

@@ -82,7 +82,7 @@ public:
 
     /// Use the account as parent
     explicit AccountState(AccountPtr account);
-    ~AccountState();
+    ~AccountState() override;
 
     /** Creates an account state from settings and an Account object.
      *

src/gui/addcertificatedialog.h

@@ -35,7 +35,7 @@ class AddCertificateDialog : public QDialog
 
 public:
     explicit AddCertificateDialog(QWidget *parent = nullptr);
-    ~AddCertificateDialog();
+    ~AddCertificateDialog() override;
     QString getCertificatePath();
     QString getCertificatePasswd();
     void showErrorMessage(const QString message);

src/gui/application.h

@@ -57,7 +57,7 @@ class Application : public SharedTools::QtSingleApplication
     Q_OBJECT
 public:
     explicit Application(int &argc, char **argv);
-    ~Application();
+    ~Application() override;
 
     bool giveHelp();
     void showHelp();
@@ -88,7 +88,7 @@ protected:
     void parseOptions(const QStringList &);
     void setupTranslations();
     void setupLogging();
-    bool event(QEvent *event);
+    bool event(QEvent *event) override;
 
 signals:
     void folderRemoved();

src/gui/cloudproviders/cloudproviderwrapper.h

@@ -39,7 +39,7 @@ class CloudProviderWrapper : public QObject
     Q_OBJECT
 public:
     explicit CloudProviderWrapper(QObject *parent = nullptr, Folder *folder = nullptr, int folderId = 0, CloudProvidersProviderExporter* cloudprovider = nullptr);
-    ~CloudProviderWrapper();
+    ~CloudProviderWrapper() override;
     CloudProvidersAccountExporter* accountExporter();
     Folder* folder();
     GMenuModel* getMenuModel();

src/gui/creds/flow2auth.h

@@ -42,7 +42,7 @@ public:
     };
 
     Flow2Auth(Account *account, QObject *parent);
-    ~Flow2Auth();
+    ~Flow2Auth() override;
 
     enum Result { NotSupported,
         LoggedIn,

src/gui/creds/oauth.h

@@ -47,7 +47,7 @@ public:
         , _account(account)
     {
     }
-    ~OAuth();
+    ~OAuth() override;
 
     enum Result { NotSupported,
         LoggedIn,

src/gui/folder.h

@@ -117,7 +117,7 @@ public:
      */
     Folder(const FolderDefinition &definition, AccountState *accountState, std::unique_ptr<Vfs> vfs, QObject *parent = nullptr);
 
-    ~Folder();
+    ~Folder() override;
 
     using Map = QMap<QString, Folder *>;
     using MapIterator = QMapIterator<QString, Folder *>;

src/gui/foldercreationdialog.h

@@ -29,7 +29,7 @@ class FolderCreationDialog : public QDialog
 
 public:
     explicit FolderCreationDialog(const QString &destination, QWidget *parent = nullptr);
-    ~FolderCreationDialog();
+    ~FolderCreationDialog() override;
 
 private slots:
     void accept() override;

src/gui/folderman.h

@@ -62,7 +62,7 @@ class FolderMan : public QObject
 {
     Q_OBJECT
 public:
-    ~FolderMan();
+    ~FolderMan() override;
     static FolderMan *instance();
 
     int setupFolders();

src/gui/folderstatusmodel.h

@@ -42,7 +42,7 @@ public:
     enum {FileIdRole = Qt::UserRole+1};
 
     FolderStatusModel(QObject *parent = nullptr);
-    ~FolderStatusModel();
+    ~FolderStatusModel() override;
     void setAccountState(const AccountState *accountState);
 
     Qt::ItemFlags flags(const QModelIndex &) const override;

src/gui/folderwatcher.h

@@ -53,7 +53,7 @@ class FolderWatcher : public QObject
 public:
     // Construct, connect signals, call init()
     explicit FolderWatcher(Folder *folder = nullptr);
-    virtual ~FolderWatcher();
+    ~FolderWatcher() override;
 
     /**
      * @param root Path of the root of the folder

src/gui/folderwatcher_linux.h

@@ -37,7 +37,7 @@ class FolderWatcherPrivate : public QObject
 public:
     FolderWatcherPrivate() = default;
     FolderWatcherPrivate(FolderWatcher *p, const QString &path);
-    ~FolderWatcherPrivate();
+    ~FolderWatcherPrivate() override;
 
     int testWatchCount() const { return _pathToWatch.size(); }
 

src/gui/folderwizard.h

@@ -53,7 +53,7 @@ class FolderWizardLocalPath : public FormatWarningsWizardPage
     Q_OBJECT
 public:
     explicit FolderWizardLocalPath(const AccountPtr &account);
-    ~FolderWizardLocalPath();
+    ~FolderWizardLocalPath() override;
 
     bool isComplete() const override;
     void initializePage() override;
@@ -80,7 +80,7 @@ class FolderWizardRemotePath : public FormatWarningsWizardPage
     Q_OBJECT
 public:
     explicit FolderWizardRemotePath(const AccountPtr &account);
-    ~FolderWizardRemotePath();
+    ~FolderWizardRemotePath() override;
 
     bool isComplete() const override;
 
@@ -124,7 +124,7 @@ class FolderWizardSelectiveSync : public QWizardPage
     Q_OBJECT
 public:
     explicit FolderWizardSelectiveSync(const AccountPtr &account);
-    ~FolderWizardSelectiveSync();
+    ~FolderWizardSelectiveSync() override;
 
     bool validatePage() override;
 
@@ -154,7 +154,7 @@ public:
     };
 
     explicit FolderWizard(AccountPtr account, QWidget *parent = nullptr);
-    ~FolderWizard();
+    ~FolderWizard() override;
 
     bool eventFilter(QObject *watched, QEvent *event) override;
     void resizeEvent(QResizeEvent *event) override;

src/gui/generalsettings.h

@@ -36,7 +36,7 @@ class GeneralSettings : public QWidget
 
 public:
     explicit GeneralSettings(QWidget *parent = nullptr);
-    ~GeneralSettings();
+    ~GeneralSettings() override;
     QSize sizeHint() const override;
 
 public slots:

src/gui/ignorelisteditor.h

@@ -36,7 +36,7 @@ class IgnoreListEditor : public QDialog
 
 public:
     IgnoreListEditor(QWidget *parent = nullptr);
-    ~IgnoreListEditor();
+    ~IgnoreListEditor() override;
 
     bool ignoreHiddenFiles();
 

src/gui/ignorelisttablewidget.h

@@ -16,7 +16,7 @@ class IgnoreListTableWidget : public QWidget
 
 public:
     IgnoreListTableWidget(QWidget *parent = nullptr);
-    ~IgnoreListTableWidget();
+    ~IgnoreListTableWidget() override;
 
     void readIgnoreFile(const QString &file, bool readOnly = false);
     int addPattern(const QString &pattern, bool deletable, bool readOnly);

src/gui/legalnotice.h

@@ -35,7 +35,7 @@ class LegalNotice : public QDialog
 
 public:
     explicit LegalNotice(QDialog *parent = nullptr);
-    ~LegalNotice();
+    ~LegalNotice() override;
 
 protected:
     void changeEvent(QEvent *) override;

src/gui/logbrowser.h

@@ -38,7 +38,7 @@ class LogBrowser : public QDialog
     Q_OBJECT
 public:
     explicit LogBrowser(QWidget *parent = nullptr);
-    ~LogBrowser();
+    ~LogBrowser() override;
 
 protected:
     void closeEvent(QCloseEvent *) override;

src/gui/networksettings.h

@@ -34,7 +34,7 @@ class NetworkSettings : public QWidget
 
 public:
     explicit NetworkSettings(QWidget *parent = nullptr);
-    ~NetworkSettings();
+    ~NetworkSettings() override;
     QSize sizeHint() const override;
 
 private slots:

src/gui/owncloudsetupwizard.h

@@ -71,7 +71,7 @@ private slots:
 
 private:
     explicit OwncloudSetupWizard(QObject *parent = nullptr);
-    ~OwncloudSetupWizard();
+    ~OwncloudSetupWizard() override;
     void startWizard();
     void testOwnCloudConnect();
     void createRemoteFolder();

src/gui/proxyauthdialog.h

@@ -34,7 +34,7 @@ class ProxyAuthDialog : public QDialog
 
 public:
     explicit ProxyAuthDialog(QWidget *parent = nullptr);
-    ~ProxyAuthDialog();
+    ~ProxyAuthDialog() override;
 
     void setProxyAddress(const QString &address);
 

src/gui/proxyauthhandler.h

@@ -49,7 +49,7 @@ class ProxyAuthHandler : public QObject
 public:
     static ProxyAuthHandler *instance();
 
-    virtual ~ProxyAuthHandler();
+    ~ProxyAuthHandler() override;
 
 public slots:
     /// Intended for QNetworkAccessManager::proxyAuthenticationRequired()

src/gui/settingsdialog.h

@@ -49,7 +49,7 @@ class SettingsDialog : public QDialog
 
 public:
     explicit SettingsDialog(ownCloudGui *gui, QWidget *parent = nullptr);
-    ~SettingsDialog();
+    ~SettingsDialog() override;
 
     QWidget* currentPage();
 

src/gui/sharedialog.h

@@ -51,7 +51,7 @@ public:
         const QByteArray &numericFileId,
         ShareDialogStartPage startPage,
         QWidget *parent = nullptr);
-    ~ShareDialog();
+    ~ShareDialog() override;
 
 private slots:
     void done(int r) override;

src/gui/sharelinkwidget.h

@@ -52,7 +52,7 @@ public:
         const QString &localPath,
         SharePermissions maxSharingPermissions,
         QWidget *parent = nullptr);
-    ~ShareLinkWidget();
+    ~ShareLinkWidget() override;
 
     void toggleButton(bool show);
     void setupUiOptions();

src/gui/shareusergroupwidget.h

@@ -59,7 +59,7 @@ public:
         SharePermissions maxSharingPermissions,
         const QString &privateLinkUrl,
         QWidget *parent = nullptr);
-    ~ShareUserGroupWidget();
+    ~ShareUserGroupWidget() override;
 
 signals:
     void togglePublicLinkShare(bool);
@@ -128,7 +128,7 @@ public:
         SharePermissions maxSharingPermissions,
         bool isFile,
         QWidget *parent = nullptr);
-    ~ShareUserLine();
+    ~ShareUserLine() override;
 
     QSharedPointer<Share> share() const;
 

src/gui/socketapi/socketapi.h

@@ -54,7 +54,7 @@ class SocketApi : public QObject
 
 public:
     explicit SocketApi(QObject *parent = nullptr);
-    virtual ~SocketApi();
+    ~SocketApi() override;
 
 public slots:
     void slotUpdateFolderView(Folder *f);

src/gui/sslerrordialog.h

@@ -49,7 +49,7 @@ class SslErrorDialog : public QDialog
     Q_OBJECT
 public:
     explicit SslErrorDialog(AccountPtr account, QWidget *parent = nullptr);
-    ~SslErrorDialog();
+    ~SslErrorDialog() override;
     bool checkFailingCertsKnown(const QList<QSslError> &errors);
     bool trustConnection();
     QList<QSslCertificate> unknownCerts() const { return _unknownCerts; }

src/gui/systray.h

@@ -48,7 +48,7 @@ class Systray
 
 public:
     static Systray *instance();
-    virtual ~Systray() = default;
+    ~Systray() override = default;
 
     enum class TaskBarPosition { Bottom, Left, Top, Right };
     Q_ENUM(TaskBarPosition);

src/gui/tray/UserModel.h

@@ -130,7 +130,7 @@ class UserModel : public QAbstractListModel
     Q_PROPERTY(int currentUserId READ currentUserId NOTIFY newUserSelected)
 public:
     static UserModel *instance();
-    virtual ~UserModel() = default;
+    ~UserModel() override = default;
 
     void addUser(AccountStatePtr &user, const bool &isCurrent = false);
     int currentUserIndex();
@@ -205,7 +205,7 @@ class UserAppsModel : public QAbstractListModel
     Q_OBJECT
 public:
     static UserAppsModel *instance();
-    virtual ~UserAppsModel() = default;
+    ~UserAppsModel() override = default;
 
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
 

src/gui/updater/sparkleupdater.h

@@ -26,7 +26,7 @@ class SparkleUpdater : public Updater
     Q_OBJECT
 public:
     SparkleUpdater(const QUrl &appCastUrl);
-    ~SparkleUpdater();
+    ~SparkleUpdater() override;
 
     void setUpdateUrl(const QUrl &url);
 

src/gui/wizard/flow2authwidget.h

@@ -31,7 +31,7 @@ class Flow2AuthWidget : public QWidget
     Q_OBJECT
 public:
     Flow2AuthWidget(QWidget *parent = nullptr);
-    virtual ~Flow2AuthWidget();
+    ~Flow2AuthWidget() override;
 
     void startAuth(Account *account);
     void resetAuth(Account *account = nullptr);

src/gui/wizard/owncloudconnectionmethoddialog.h

@@ -36,7 +36,7 @@ class OwncloudConnectionMethodDialog : public QDialog
 
 public:
     explicit OwncloudConnectionMethodDialog(QWidget *parent = nullptr);
-    ~OwncloudConnectionMethodDialog();
+    ~OwncloudConnectionMethodDialog() override;
     enum {
         Closed = 0,
         No_TLS,

src/gui/wizard/owncloudsetuppage.h

@@ -43,7 +43,7 @@ class OwncloudSetupPage : public QWizardPage
     Q_OBJECT
 public:
     OwncloudSetupPage(QWidget *parent = nullptr);
-    ~OwncloudSetupPage();
+    ~OwncloudSetupPage() override;
 
     bool isComplete() const override;
     void initializePage() override;

src/gui/wizard/owncloudwizardresultpage.h

@@ -31,7 +31,7 @@ class OwncloudWizardResultPage : public QWizardPage
     Q_OBJECT
 public:
     OwncloudWizardResultPage();
-    ~OwncloudWizardResultPage();
+    ~OwncloudWizardResultPage() override;
 
     bool isComplete() const override;
     void initializePage() override;

src/gui/wizard/webview.h

@@ -21,7 +21,7 @@ class WebView : public QWidget
     Q_OBJECT
 public:
     WebView(QWidget *parent = nullptr);
-    virtual ~WebView();
+    ~WebView() override;
     void setUrl(const QUrl &url);
 
 signals:

src/gui/wizard/webviewpage.h

@@ -14,7 +14,7 @@ class WebViewPage : public AbstractCredentialsWizardPage
     Q_OBJECT
 public:
     WebViewPage(QWidget *parent = nullptr);
-    ~WebViewPage();
+    ~WebViewPage() override;
 
     void initializePage() override;
     void cleanupPage() override;

src/libsync/abstractnetworkjob.h

@@ -41,7 +41,7 @@ class OWNCLOUDSYNC_EXPORT AbstractNetworkJob : public QObject
     Q_OBJECT
 public:
     explicit AbstractNetworkJob(AccountPtr account, const QString &path, QObject *parent = nullptr);
-    virtual ~AbstractNetworkJob();
+    ~AbstractNetworkJob() override;
 
     virtual void start();
 

src/libsync/abstractpropagateremotedeleteencrypted.h

@@ -32,7 +32,7 @@ class AbstractPropagateRemoteDeleteEncrypted : public QObject
     Q_OBJECT
 public:
     AbstractPropagateRemoteDeleteEncrypted(OwncloudPropagator *propagator, SyncFileItemPtr item, QObject *parent);
-    virtual ~AbstractPropagateRemoteDeleteEncrypted() = default;
+    ~AbstractPropagateRemoteDeleteEncrypted() override = default;
 
     QNetworkReply::NetworkError networkError() const;
     QString errorString() const;

src/libsync/account.h

@@ -84,7 +84,7 @@ class OWNCLOUDSYNC_EXPORT Account : public QObject
 
 public:
     static AccountPtr create();
-    ~Account();
+    ~Account() override;
 
     AccountPtr sharedFromThis();
 

src/libsync/bandwidthmanager.h

@@ -35,7 +35,7 @@ class BandwidthManager : public QObject
     Q_OBJECT
 public:
     BandwidthManager(OwncloudPropagator *p);
-    ~BandwidthManager();
+    ~BandwidthManager() override;
 
     bool usingAbsoluteUploadLimit() { return _currentUploadLimit > 0; }
     bool usingRelativeUploadLimit() { return _currentUploadLimit < 0; }

src/libsync/cookiejar.h

@@ -30,7 +30,7 @@ class OWNCLOUDSYNC_EXPORT CookieJar : public QNetworkCookieJar
     Q_OBJECT
 public:
     explicit CookieJar(QObject *parent = nullptr);
-    ~CookieJar();
+    ~CookieJar() override;
     bool setCookiesFromUrl(const QList<QNetworkCookie> &cookieList, const QUrl &url) override;
     QList<QNetworkCookie> cookiesForUrl(const QUrl &url) const override;
 

src/libsync/creds/keychainchunk.h

@@ -45,7 +45,7 @@ class OWNCLOUDSYNC_EXPORT Job : public QObject
 public:
     Job(QObject *parent = nullptr);
 
-    virtual ~Job();
+    ~Job() override;
 
     QKeychain::Error error() const;
     QString errorString() const;

src/libsync/owncloudpropagator.h

@@ -192,7 +192,7 @@ public:
         // As an alternative, we could optimize Lock/Unlock calls, so we do a batch-write on one folder and only lock and unlock a folder once per batch.
         _parallelism = (_item->_isEncrypted || hasEncryptedAncestor()) ? WaitForFinished : FullParallelism;
     }
-    ~PropagateItemJob();
+    ~PropagateItemJob() override;
 
     bool scheduleSelfOrChild() override
     {
@@ -206,7 +206,7 @@ public:
         return true;
     }
 
-    virtual JobParallelism parallelism() override { return _parallelism; }
+    JobParallelism parallelism() override { return _parallelism; }
 
     SyncFileItemPtr _item;
 
@@ -237,7 +237,7 @@ public:
     // Don't delete jobs in _jobsToDo and _runningJobs: they have parents
     // that will be responsible for cleanup. Deleting them here would risk
     // deleting something that has already been deleted by a shared parent.
-    virtual ~PropagatorCompositeJob() = default;
+    ~PropagatorCompositeJob() override = default;
 
     void appendJob(PropagatorJob *job);
     void appendTask(const SyncFileItemPtr &item)
@@ -419,7 +419,7 @@ public:
         qRegisterMetaType<PropagatorJob::AbortType>("PropagatorJob::AbortType");
     }
 
-    ~OwncloudPropagator();
+    ~OwncloudPropagator() override;
 
     void start(SyncFileItemVector &&_syncedItems);
 
@@ -646,7 +646,7 @@ public:
     {
     }
 
-    ~CleanupPollsJob();
+    ~CleanupPollsJob() override;
 
     /**
      * Start the job.  After the job is completed, it will emit either finished or aborted, and it

src/libsync/progressdispatcher.h

@@ -269,7 +269,7 @@ class OWNCLOUDSYNC_EXPORT ProgressDispatcher : public QObject
     friend class Folder; // only allow Folder class to access the setting slots.
 public:
     static ProgressDispatcher *instance();
-    ~ProgressDispatcher();
+    ~ProgressDispatcher() override;
 
 signals:
     /**

src/libsync/propagatedownload.h

@@ -62,7 +62,7 @@ public:
     explicit GETFileJob(AccountPtr account, const QUrl &url, QIODevice *device,
         const QMap<QByteArray, QByteArray> &headers, const QByteArray &expectedEtagForResume,
         qint64 resumeStart, QObject *parent = nullptr);
-    virtual ~GETFileJob()
+    ~GETFileJob() override
     {
         if (_bandwidthManager) {
             _bandwidthManager->unregisterDownloadJob(this);
@@ -139,10 +139,10 @@ public:
     explicit GETEncryptedFileJob(AccountPtr account, const QUrl &url, QIODevice *device,
         const QMap<QByteArray, QByteArray> &headers, const QByteArray &expectedEtagForResume,
         qint64 resumeStart, EncryptedFile encryptedInfo, QObject *parent = nullptr);
-    virtual ~GETEncryptedFileJob() = default;
+    ~GETEncryptedFileJob() override = default;
 
 protected:
-    virtual qint64 writeToDevice(const QByteArray &data) override;
+    qint64 writeToDevice(const QByteArray &data) override;
 
 private:
     QSharedPointer<EncryptionHelper::StreamingDecryptor> _decryptor;

src/libsync/propagateremotedeleteencrypted.h

@@ -24,7 +24,7 @@ class PropagateRemoteDeleteEncrypted : public AbstractPropagateRemoteDeleteEncry
 public:
     PropagateRemoteDeleteEncrypted(OwncloudPropagator *propagator, SyncFileItemPtr item, QObject *parent);
 
-    virtual void start() Q_DECL_OVERRIDE;
+    void start() Q_DECL_OVERRIDE;
 
 private:
     void slotFolderUnLockedSuccessfully(const QByteArray &folderId) override;

src/libsync/propagateremotedeleteencryptedrootfolder.h

@@ -27,7 +27,7 @@ class PropagateRemoteDeleteEncryptedRootFolder : public AbstractPropagateRemoteD
 public:
     PropagateRemoteDeleteEncryptedRootFolder(OwncloudPropagator *propagator, SyncFileItemPtr item, QObject *parent);
 
-    virtual void start() Q_DECL_OVERRIDE;
+    void start() Q_DECL_OVERRIDE;
 
 private:
     void slotFolderUnLockedSuccessfully(const QByteArray &folderId) override;

src/libsync/propagateupload.h

@@ -39,7 +39,7 @@ class UploadDevice : public QIODevice
     Q_OBJECT
 public:
     UploadDevice(const QString &fileName, qint64 start, qint64 size, BandwidthManager *bwm);
-    ~UploadDevice();
+    ~UploadDevice() override;
 
     bool open(QIODevice::OpenMode mode) override;
     void close() override;
@@ -118,7 +118,7 @@ public:
     {
         _device->setParent(this);
     }
-    ~PUTFileJob();
+    ~PUTFileJob() override;
 
     int _chunk;
 

src/libsync/propagateuploadencrypted.h

@@ -33,7 +33,7 @@ class PropagateUploadEncrypted : public QObject
   Q_OBJECT
 public:
     PropagateUploadEncrypted(OwncloudPropagator *propagator, const QString &remoteParentPath, SyncFileItemPtr item, QObject *parent = nullptr);
-    ~PropagateUploadEncrypted() = default;
+    ~PropagateUploadEncrypted() override = default;
 
     void start();
 

src/libsync/pushnotifications.h

@@ -31,7 +31,7 @@ class OWNCLOUDSYNC_EXPORT PushNotifications : public QObject
 public:
     explicit PushNotifications(Account *account, QObject *parent = nullptr);
 
-    ~PushNotifications();
+    ~PushNotifications() override;
 
     /**
      * Setup push notifications

src/libsync/syncengine.h

@@ -59,7 +59,7 @@ class OWNCLOUDSYNC_EXPORT SyncEngine : public QObject
 public:
     SyncEngine(AccountPtr account, const QString &localPath,
         const QString &remotePath, SyncJournalDb *journal);
-    ~SyncEngine();
+    ~SyncEngine() override;
 
     Q_INVOKABLE void startSync();
     void setNetworkLimits(int upload, int download);

src/libsync/theme.h

@@ -72,7 +72,7 @@ public:
     /* returns a singleton instance. */
     static Theme *instance();
 
-    ~Theme();
+    ~Theme() override;
 
     /**
      * @brief isBranded indicates if the current application is branded

src/libsync/vfs/suffix/vfs_suffix.h

@@ -27,7 +27,7 @@ class VfsSuffix : public Vfs
 
 public:
     explicit VfsSuffix(QObject *parent = nullptr);
-    ~VfsSuffix();
+    ~VfsSuffix() override;
 
     Mode mode() const override;
     QString fileSuffix() const override;

src/libsync/vfs/xattr/vfs_xattr.h

@@ -27,7 +27,7 @@ class VfsXAttr : public Vfs
 
 public:
     explicit VfsXAttr(QObject *parent = nullptr);
-    ~VfsXAttr();
+    ~VfsXAttr() override;
 
     Mode mode() const override;
     QString fileSuffix() const override;

test/pushnotificationstestutils.h

@@ -29,7 +29,7 @@ class FakeWebSocketServer : public QObject
 public:
     explicit FakeWebSocketServer(quint16 port = 12345, QObject *parent = nullptr);
 
-    ~FakeWebSocketServer();
+    ~FakeWebSocketServer() override;
 
     QWebSocket *authenticateAccount(
         const OCC::AccountPtr account, std::function<void(OCC::PushNotifications *pushNotifications)> beforeAuthentication = [](OCC::PushNotifications *) {}, std::function<void(void)> afterAuthentication = [] {});
@@ -70,18 +70,18 @@ class CredentialsStub : public OCC::AbstractCredentials
 
 public:
     CredentialsStub(const QString &user, const QString &password);
-    virtual QString authType() const;
-    virtual QString user() const;
-    virtual QString password() const;
-    virtual QNetworkAccessManager *createQNAM() const;
-    virtual bool ready() const;
-    virtual void fetchFromKeychain();
-    virtual void askFromUser();
-
-    virtual bool stillValid(QNetworkReply *reply);
-    virtual void persist();
-    virtual void invalidateToken();
-    virtual void forgetSensitiveData();
+    QString authType() const override;
+    QString user() const override;
+    QString password() const override;
+    QNetworkAccessManager *createQNAM() const override;
+    bool ready() const override;
+    void fetchFromKeychain() override;
+    void askFromUser() override;
+
+    bool stillValid(QNetworkReply *reply) override;
+    void persist() override;
+    void invalidateToken() override;
+    void forgetSensitiveData() override;
 
 private:
     QString _user;

test/syncenginetestutils.h

@@ -175,7 +175,7 @@ class FakeReply : public QNetworkReply
     Q_OBJECT
 public:
     FakeReply(QObject *parent);
-    virtual ~FakeReply();
+    ~FakeReply() override;
 
     // useful to be public for testing
     using QNetworkReply::setRawHeader;
@@ -414,17 +414,17 @@ class FakeCredentials : public OCC::AbstractCredentials
     QNetworkAccessManager *_qnam;
 public:
     FakeCredentials(QNetworkAccessManager *qnam) : _qnam{qnam} { }
-    virtual QString authType() const { return "test"; }
-    virtual QString user() const { return "admin"; }
-    virtual QString password() const { return "password"; }
-    virtual QNetworkAccessManager *createQNAM() const { return _qnam; }
-    virtual bool ready() const { return true; }
-    virtual void fetchFromKeychain() { }
-    virtual void askFromUser() { }
-    virtual bool stillValid(QNetworkReply *) { return true; }
-    virtual void persist() { }
-    virtual void invalidateToken() { }
-    virtual void forgetSensitiveData() { }
+    QString authType() const override { return "test"; }
+    QString user() const override { return "admin"; }
+    QString password() const override { return "password"; }
+    QNetworkAccessManager *createQNAM() const override { return _qnam; }
+    bool ready() const override { return true; }
+    void fetchFromKeychain() override { }
+    void askFromUser() override { }
+    bool stillValid(QNetworkReply *) override { return true; }
+    void persist() override { }
+    void invalidateToken() override { }
+    void forgetSensitiveData() override { }
 };
 
 class FakeFolder