Browse Source

Jenkinsfile: Some comments

Markus Goetz 8 years ago
parent
commit
59bbbd5e66
2 changed files with 15 additions and 0 deletions
  1. 9 0
      Jenkinsfile
  2. 6 0
      test/syncenginetestutils.h

+ 9 - 0
Jenkinsfile

@@ -1,5 +1,12 @@
 #!groovy
 
+//
+// We now run the tests in Debug mode so that ASSERTs are triggered.
+// Ideally we should run the tests in both Debug and Release so we catch
+// all possible error combinations.
+// See also the top comment in syncenginetestutils.h
+//
+
 node('CLIENT') {
     stage 'Checkout'
         checkout scm
@@ -37,6 +44,8 @@ node('CLIENT') {
 		ctest .
 		'''
 	}
+
+   // Stage 'macOS' TODO
 }
 
 

+ 6 - 0
test/syncenginetestutils.h

@@ -17,6 +17,12 @@
 #include <QMap>
 #include <QtTest>
 
+/*
+ * TODO: In theory we should use QVERIFY instead of Q_ASSERT for testing, but this
+ * only works when directly called from a QTest :-(
+ */
+
+
 static const QUrl sRootUrl("owncloud://somehost/owncloud/remote.php/webdav/");
 static const QUrl sRootUrl2("owncloud://somehost/owncloud/remote.php/dav/files/admin/");
 static const QUrl sUploadUrl("owncloud://somehost/owncloud/remote.php/dav/uploads/admin/");