testsyncfilestatustracker.cpp 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444
  1. /*
  2. * This software is in the public domain, furnished "as is", without technical
  3. * support, and with no warranty, express or implied, as to its usefulness for
  4. * any purpose.
  5. *
  6. */
  7. #include <QtTest>
  8. #include "syncenginetestutils.h"
  9. using namespace OCC;
  10. class StatusPushSpy : public QSignalSpy
  11. {
  12. SyncEngine &_syncEngine;
  13. public:
  14. StatusPushSpy(SyncEngine &syncEngine)
  15. : QSignalSpy(&syncEngine.syncFileStatusTracker(), SIGNAL(fileStatusChanged(const QString&, SyncFileStatus)))
  16. , _syncEngine(syncEngine)
  17. { }
  18. SyncFileStatus statusOf(const QString &relativePath) const {
  19. QFileInfo file(_syncEngine.localPath(), relativePath);
  20. // Start from the end to get the latest status
  21. for (int i = size() - 1; i >= 0; --i) {
  22. if (QFileInfo(at(i)[0].toString()) == file)
  23. return at(i)[1].value<SyncFileStatus>();
  24. }
  25. return SyncFileStatus();
  26. }
  27. bool statusEmittedBefore(const QString &firstPath, const QString &secondPath) const {
  28. QFileInfo firstFile(_syncEngine.localPath(), firstPath);
  29. QFileInfo secondFile(_syncEngine.localPath(), secondPath);
  30. // Start from the end to get the latest status
  31. int i = size() - 1;
  32. for (; i >= 0; --i) {
  33. if (QFileInfo(at(i)[0].toString()) == secondFile)
  34. break;
  35. else if (QFileInfo(at(i)[0].toString()) == firstFile)
  36. return false;
  37. }
  38. for (; i >= 0; --i) {
  39. if (QFileInfo(at(i)[0].toString()) == firstFile)
  40. return true;
  41. }
  42. return false;
  43. }
  44. };
  45. class TestSyncFileStatusTracker : public QObject
  46. {
  47. Q_OBJECT
  48. void verifyThatPushMatchesPull(const FakeFolder &fakeFolder, const StatusPushSpy &statusSpy) {
  49. QString root = fakeFolder.localPath();
  50. QDirIterator it(root, QDir::AllEntries | QDir::NoDotAndDotDot, QDirIterator::Subdirectories);
  51. while (it.hasNext()) {
  52. QString filePath = it.next().mid(root.size());
  53. SyncFileStatus pushedStatus = statusSpy.statusOf(filePath);
  54. if (pushedStatus != SyncFileStatus())
  55. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus(filePath), pushedStatus);
  56. }
  57. }
  58. private slots:
  59. void parentsGetSyncStatusUploadDownload() {
  60. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  61. fakeFolder.localModifier().appendByte("B/b1");
  62. fakeFolder.remoteModifier().appendByte("C/c1");
  63. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  64. fakeFolder.scheduleSync();
  65. fakeFolder.execUntilBeforePropagation();
  66. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  67. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  68. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  69. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusSync));
  70. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusSync));
  71. QCOMPARE(statusSpy.statusOf("C/c1"), SyncFileStatus(SyncFileStatus::StatusSync));
  72. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  73. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  74. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("B/b2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  75. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("C/c2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  76. statusSpy.clear();
  77. fakeFolder.execUntilFinished();
  78. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  79. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  80. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  81. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  82. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  83. QCOMPARE(statusSpy.statusOf("C/c1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  84. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  85. }
  86. void parentsGetSyncStatusNewFileUploadDownload() {
  87. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  88. fakeFolder.localModifier().insert("B/b0");
  89. fakeFolder.remoteModifier().insert("C/c0");
  90. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  91. fakeFolder.scheduleSync();
  92. fakeFolder.execUntilBeforePropagation();
  93. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  94. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  95. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  96. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusSync));
  97. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusSync));
  98. QCOMPARE(statusSpy.statusOf("C/c0"), SyncFileStatus(SyncFileStatus::StatusSync));
  99. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  100. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  101. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("B/b1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  102. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("C/c1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  103. statusSpy.clear();
  104. fakeFolder.execUntilFinished();
  105. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  106. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  107. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  108. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  109. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  110. QCOMPARE(statusSpy.statusOf("C/c0"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  111. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  112. }
  113. void parentsGetSyncStatusNewDirDownload() {
  114. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  115. fakeFolder.remoteModifier().mkdir("D");
  116. fakeFolder.remoteModifier().insert("D/d0");
  117. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  118. fakeFolder.scheduleSync();
  119. fakeFolder.execUntilBeforePropagation();
  120. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  121. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  122. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusSync));
  123. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusSync));
  124. fakeFolder.execUntilItemCompleted("D");
  125. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  126. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  127. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusSync));
  128. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusSync));
  129. fakeFolder.execUntilFinished();
  130. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  131. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  132. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  133. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  134. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  135. }
  136. void parentsGetSyncStatusNewDirUpload() {
  137. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  138. fakeFolder.localModifier().mkdir("D");
  139. fakeFolder.localModifier().insert("D/d0");
  140. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  141. fakeFolder.scheduleSync();
  142. fakeFolder.execUntilBeforePropagation();
  143. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  144. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  145. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusSync));
  146. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusSync));
  147. fakeFolder.execUntilItemCompleted("D");
  148. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  149. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  150. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusSync));
  151. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusSync));
  152. fakeFolder.execUntilFinished();
  153. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  154. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  155. QCOMPARE(statusSpy.statusOf("D"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  156. QCOMPARE(statusSpy.statusOf("D/d0"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  157. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  158. }
  159. void parentsGetSyncStatusDeleteUpDown() {
  160. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  161. fakeFolder.remoteModifier().remove("B/b1");
  162. fakeFolder.localModifier().remove("C/c1");
  163. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  164. fakeFolder.scheduleSync();
  165. fakeFolder.execUntilBeforePropagation();
  166. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  167. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  168. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  169. // Discovered as remotely removed, pending for local removal.
  170. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusSync));
  171. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusSync));
  172. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  173. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("B/b2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  174. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("C/c2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  175. statusSpy.clear();
  176. fakeFolder.execUntilFinished();
  177. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  178. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  179. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  180. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  181. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  182. }
  183. void warningStatusForExcludedFile() {
  184. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  185. fakeFolder.syncEngine().excludedFiles().addExcludeExpr("A/a1");
  186. fakeFolder.syncEngine().excludedFiles().addExcludeExpr("B");
  187. fakeFolder.localModifier().appendByte("A/a1");
  188. fakeFolder.localModifier().appendByte("B/b1");
  189. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  190. fakeFolder.scheduleSync();
  191. fakeFolder.execUntilBeforePropagation();
  192. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  193. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusWarning));
  194. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  195. QEXPECT_FAIL("", "csync will stop at ignored directories without traversing children, so we don't currently push the status for newly ignored children of an ignored directory.", Continue);
  196. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusWarning));
  197. fakeFolder.execUntilFinished();
  198. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  199. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusWarning));
  200. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  201. QEXPECT_FAIL("", "csync will stop at ignored directories without traversing children, so we don't currently push the status for newly ignored children of an ignored directory.", Continue);
  202. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusWarning));
  203. QEXPECT_FAIL("", "csync will stop at ignored directories without traversing children, so we don't currently push the status for newly ignored children of an ignored directory.", Continue);
  204. QCOMPARE(statusSpy.statusOf("B/b2"), SyncFileStatus(SyncFileStatus::StatusWarning));
  205. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  206. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  207. statusSpy.clear();
  208. // Clears the exclude expr above
  209. fakeFolder.syncEngine().excludedFiles().reloadExcludes();
  210. fakeFolder.scheduleSync();
  211. fakeFolder.execUntilBeforePropagation();
  212. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  213. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusSync));
  214. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusSync));
  215. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  216. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusSync));
  217. statusSpy.clear();
  218. fakeFolder.execUntilFinished();
  219. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  220. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  221. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  222. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  223. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  224. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  225. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  226. }
  227. void parentsGetWarningStatusForError() {
  228. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  229. fakeFolder.serverErrorPaths().append("A/a1");
  230. fakeFolder.serverErrorPaths().append("B/b0");
  231. fakeFolder.localModifier().appendByte("A/a1");
  232. fakeFolder.localModifier().insert("B/b0");
  233. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  234. fakeFolder.scheduleSync();
  235. fakeFolder.execUntilBeforePropagation();
  236. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  237. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  238. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusSync));
  239. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusSync));
  240. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  241. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusSync));
  242. statusSpy.clear();
  243. fakeFolder.execUntilFinished();
  244. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  245. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusWarning));
  246. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  247. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  248. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  249. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  250. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusError));
  251. statusSpy.clear();
  252. // Remove the error and start a second sync, the blacklist should kick in
  253. fakeFolder.serverErrorPaths().clear();
  254. fakeFolder.scheduleSync();
  255. fakeFolder.execUntilBeforePropagation();
  256. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  257. // A/a1 and B/b0 should be on the black list for the next few seconds
  258. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusWarning));
  259. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  260. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  261. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  262. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusError));
  263. statusSpy.clear();
  264. fakeFolder.execUntilFinished();
  265. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  266. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusWarning));
  267. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  268. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  269. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  270. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  271. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusError));
  272. statusSpy.clear();
  273. // Start a third sync, this time together with a real file to sync
  274. fakeFolder.localModifier().appendByte("C/c1");
  275. fakeFolder.scheduleSync();
  276. fakeFolder.execUntilBeforePropagation();
  277. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  278. // The root should show SYNC even though there is an error underneath,
  279. // since C/c1 is syncing and the SYNC status has priority.
  280. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  281. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  282. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  283. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  284. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusError));
  285. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusSync));
  286. QCOMPARE(statusSpy.statusOf("C/c1"), SyncFileStatus(SyncFileStatus::StatusSync));
  287. statusSpy.clear();
  288. fakeFolder.execUntilFinished();
  289. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  290. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusWarning));
  291. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  292. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  293. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a2"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  294. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusWarning));
  295. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusError));
  296. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  297. QCOMPARE(statusSpy.statusOf("C/c1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  298. statusSpy.clear();
  299. // Another sync after clearing the blacklist entry, everything should return to order.
  300. fakeFolder.syncEngine().journal()->wipeErrorBlacklistEntry("A/a1");
  301. fakeFolder.syncEngine().journal()->wipeErrorBlacklistEntry("B/b0");
  302. fakeFolder.scheduleSync();
  303. fakeFolder.execUntilBeforePropagation();
  304. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  305. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  306. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusSync));
  307. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusSync));
  308. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusSync));
  309. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusSync));
  310. statusSpy.clear();
  311. fakeFolder.execUntilFinished();
  312. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  313. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  314. QCOMPARE(statusSpy.statusOf("A"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  315. QCOMPARE(statusSpy.statusOf("A/a1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  316. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  317. QCOMPARE(statusSpy.statusOf("B/b0"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  318. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  319. }
  320. void parentsGetWarningStatusForError_SibblingStartsWithPath() {
  321. // A is a parent of A/a1, but A/a is not even if it's a substring of A/a1
  322. FakeFolder fakeFolder{{QString{},{
  323. {QStringLiteral("A"), {
  324. {QStringLiteral("a"), 4},
  325. {QStringLiteral("a1"), 4}
  326. }}}}};
  327. fakeFolder.serverErrorPaths().append("A/a1");
  328. fakeFolder.localModifier().appendByte("A/a1");
  329. fakeFolder.scheduleSync();
  330. fakeFolder.execUntilBeforePropagation();
  331. // The SyncFileStatusTraker won't push any status for all of them, test with a pull.
  332. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus(""), SyncFileStatus(SyncFileStatus::StatusSync));
  333. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusSync));
  334. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a1"), SyncFileStatus(SyncFileStatus::StatusSync));
  335. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  336. fakeFolder.execUntilFinished();
  337. // We use string matching for paths in the implementation,
  338. // an error should affect only parents and not every path that starts with the problem path.
  339. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus(""), SyncFileStatus(SyncFileStatus::StatusWarning));
  340. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A"), SyncFileStatus(SyncFileStatus::StatusWarning));
  341. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a1"), SyncFileStatus(SyncFileStatus::StatusError));
  342. QCOMPARE(fakeFolder.syncEngine().syncFileStatusTracker().fileStatus("A/a"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  343. }
  344. // Even for status pushes immediately following each other, macOS
  345. // can sometimes have 1s delays between updates, so make sure that
  346. // children are marked as OK before their parents do.
  347. void childOKEmittedBeforeParent() {
  348. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  349. fakeFolder.localModifier().appendByte("B/b1");
  350. fakeFolder.remoteModifier().appendByte("C/c1");
  351. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  352. fakeFolder.syncOnce();
  353. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  354. QVERIFY(statusSpy.statusEmittedBefore("B/b1", "B"));
  355. QVERIFY(statusSpy.statusEmittedBefore("C/c1", "C"));
  356. QVERIFY(statusSpy.statusEmittedBefore("B", ""));
  357. QVERIFY(statusSpy.statusEmittedBefore("C", ""));
  358. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  359. QCOMPARE(statusSpy.statusOf("B"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  360. QCOMPARE(statusSpy.statusOf("B/b1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  361. QCOMPARE(statusSpy.statusOf("C"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  362. QCOMPARE(statusSpy.statusOf("C/c1"), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  363. }
  364. void sharedStatus() {
  365. SyncFileStatus sharedUpToDateStatus(SyncFileStatus::StatusUpToDate);
  366. sharedUpToDateStatus.setSharedWithMe(true);
  367. FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
  368. fakeFolder.remoteModifier().insert("S/s0");
  369. fakeFolder.remoteModifier().appendByte("S/s1");
  370. StatusPushSpy statusSpy(fakeFolder.syncEngine());
  371. fakeFolder.scheduleSync();
  372. fakeFolder.execUntilBeforePropagation();
  373. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  374. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusSync));
  375. // We don't care about the shared flag for the sync status,
  376. // Mac and Windows won't show it and we can't know it for new files.
  377. QCOMPARE(statusSpy.statusOf("S").tag(), SyncFileStatus::StatusSync);
  378. QCOMPARE(statusSpy.statusOf("S/s0").tag(), SyncFileStatus::StatusSync);
  379. QCOMPARE(statusSpy.statusOf("S/s1").tag(), SyncFileStatus::StatusSync);
  380. fakeFolder.execUntilFinished();
  381. verifyThatPushMatchesPull(fakeFolder, statusSpy);
  382. QCOMPARE(statusSpy.statusOf(""), SyncFileStatus(SyncFileStatus::StatusUpToDate));
  383. QCOMPARE(statusSpy.statusOf("S"), sharedUpToDateStatus);
  384. QEXPECT_FAIL("", "We currently only know if a new file is shared on the second sync, after a PROPFIND.", Continue);
  385. QCOMPARE(statusSpy.statusOf("S/s0"), sharedUpToDateStatus);
  386. QCOMPARE(statusSpy.statusOf("S/s1"), sharedUpToDateStatus);
  387. QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
  388. }
  389. };
  390. QTEST_GUILESS_MAIN(TestSyncFileStatusTracker)
  391. #include "testsyncfilestatustracker.moc"